Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove explicit conversion to NodeRef in GqlGraph associated functions if they are not needed #1829

Open
ricopinazo opened this issue Oct 17, 2024 · 0 comments
Open

Remove explicit conversion to NodeRef in GqlGraph associated functions if they are not needed #1829

ricopinazo opened this issue Oct 17, 2024 · 0 comments
Assignees
@ricopinazo

Comments

@ricopinazo
Copy link
Contributor

ricopinazo commented Oct 17, 2024 •
edited
Loading

If you go to raphtory-graphql/src/mode/graph/graph.rs you will find that for many functions, such as subgraph_id, we are explicitly converting to NodeRef instead of using the node objects directly. Is this really necessary or can we skip that?
@ricopinazo ricopinazo changed the title Remove explicit conversion to node refs in GqlGraph associated functions if they are not needed Remove explicit conversion to NodeRef in GqlGraph associated functions if they are not needed Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ricopinazo ricopinazo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ricopinazo