Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

min_turns and max_turns are not correct #1154

Open
youssef007 opened this issue Oct 24, 2024 · 5 comments
Open

min_turns and max_turns are not correct #1154

youssef007 opened this issue Oct 24, 2024 · 5 comments

Comments

@youssef007
Copy link

min_turns and max_turns for moves like Wrap and Infestation are wrong, in the api data it is marked they are 5-6 but in the discription they are 2-5, also there is no way to retrieve min rounds and max rounds for moves like thrash.

@Naramsim
Copy link
Member

Hi, are these wrong values maybe outdated? Maybe those values were correct for older games and now they became obsolete?

@youssef007
Copy link
Author

I don't think that any older game has 5-6 turns for moves like thrash

@Naramsim
Copy link
Member

Naramsim commented Nov 1, 2024

Oh, ok, so the data is wrong. Could you try and fix it? Or some initially just a move so that you see how the data is structured and I can review the changes?

@thehecktour
Copy link

Hi @Naramsim , It's been 3 weeks and the guy hasn't said anything and I haven't seen his PR open or/and closed, so I'm going to work on this solution.

@Naramsim
Copy link
Member

Whao! Thanks a lot! Yes! Maybe do research first in Bulbapedia and then go ahead with the CSVs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants