Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extractSignatures new arguments #646

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

extractSignatures new arguments #646

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Dec 21, 2020

Hello @PoisonAlien,

Added absolute contribution argument and an option to bump up nruns from 1 for extractSignatures function. By default set the new nrun to 1 and absolute parameter to FALSE. If absolute set to true, it will create non-adjusted h_absolute and return it as part of the list under absolute_contributions. Hopefully this is helpful.

Modified R documentation accordingly.

Discussed #645.

Added absolute contribution argument and an option to increase nruns from default 1 for extractSignatures function. Modified R documentation accordingly.
@ghost ghost changed the title extractSignatures new arguments #645 extractSignatures new arguments Dec 21, 2020
@ShixiangWang
Copy link
Contributor

@TescoOriginal Please pay attention that the absolute exposure is not the H matrix, it should be scaled.

Here is what I did in sigminer:

https://github.com/ShixiangWang/sigminer/blob/565fe651eee486e015db13b816de93bf54f784e0/R/helper_scale_nmf_matrix.R#L22-L25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants