Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leftover identified on code review of PR #218 #232

Closed
dellagustin opened this issue Feb 12, 2023 · 3 comments
Closed

Leftover identified on code review of PR #218 #232

dellagustin opened this issue Feb 12, 2023 · 3 comments

Comments

@dellagustin
Copy link
Contributor

See #218 (comment).

Low priority. It is only a sanity check and it is not failing when all is working.

@daveajones , you can assign this one to me.
@dellagustin dellagustin mentioned this issue Feb 12, 2023
Merged
11 tasks
@dellagustin dellagustin mentioned this issue May 16, 2023
Merged
@dellagustin dellagustin changed the title Left over identified on code review of PR #218 Leftover identified on code review of PR #218 May 18, 2023
@dellagustin
Copy link
Contributor Author

will be fixed with #266.

@stevencrader
Copy link
Collaborator

Can this be closed?

@dellagustin
Copy link
Contributor Author

Yes, thank you @stevencrader the reminder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dellagustin @stevencrader