Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getCollateral may return null #1560

Closed
klntsky opened this issue Nov 20, 2023 · 1 comment
Closed

getCollateral may return null #1560

klntsky opened this issue Nov 20, 2023 · 1 comment

Comments

@klntsky
Copy link
Member

klntsky commented Nov 20, 2023

According to CIP-30:

api.getCollateral(params: { amount: cbor\<Coin> }): Promise\<TransactionUnspentOutput[] | null>

We don't handle null properly.
@klntsky
Copy link
Member Author

klntsky commented Dec 9, 2023

cardano-transaction-lib/src/Internal/Wallet/Cip30.js

Line 13 in 199f6de

utxos !== null && utxos.length ? maybe.just(utxos) : maybe.nothing

@klntsky klntsky closed this as completed Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@klntsky