Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting epochSize in Plutip breaks staking tests #1272

Open
klntsky opened this issue Nov 29, 2022 · 3 comments
Open

Setting epochSize in Plutip breaks staking tests #1272

klntsky opened this issue Nov 29, 2022 · 3 comments
Labels
bug Something isn't working plutip plutip integration (#426)

Comments

@klntsky
Copy link
Member

klntsky commented Nov 29, 2022

When using plutip revision from the current master, npm run staking-test fails because rewards are never received. Something changed in how staking pools operate on a temporary local cluster. We need to identify the problem, fix it, and switch to the newest plutip revision.

As a bonus, we will be able to use the newly introduced plutip-server cluster startup parameters (slot length and epoch size)
@klntsky klntsky added the bug Something isn't working label Nov 29, 2022
@klntsky klntsky added the plutip plutip integration (#426) label Nov 29, 2022
@klntsky klntsky changed the title Saking tests do not work with newer plutip versions Staking tests do not work with newer plutip versions Nov 29, 2022
@uhbif19
Copy link
Contributor

uhbif19 commented Dec 5, 2022

@klntsky

Looks like there is a related bug in Plutip: mlabs-haskell/plutip#149

So I think this issue is blocked by Plutip bug?

@klntsky klntsky added the blocked label Dec 5, 2022
@bradley-heather
Copy link
Contributor

bradley-heather commented Dec 9, 2022 •
edited
Loading

The Issue lies in the epochSize. I wouldn't be surprised if IOHK has it hard coded somewhere in the staking code. However we can still freely change slotLength and update to the latest Plutip revision provided epochSize remains at 80

@bradley-heather bradley-heather changed the title Staking tests do not work with newer plutip versions epochSize is not configurable with Plutip as it breaks staking tests Dec 13, 2022
@klntsky klntsky changed the title epochSize is not configurable with Plutip as it breaks staking tests Setting epochSize in Plutip breaks staking tests Oct 5, 2023
@klntsky
Copy link
Member Author

klntsky commented Jul 31, 2024

We don't have plutip anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working plutip plutip integration (#426)
Projects
cardano-transaction-lib
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
3 participants
@uhbif19 @klntsky @bradley-heather