RFC Geolocation endpoints

[Edilberto-Vazquez]

Hi everyone, this is our RFC #29 me and my partner don't have much experience with backend and we appreciate your feedback about our RFC

[gh0stl1m]

@Edilberto-Vazquez congratulations the RFCs is pretty good and well explained and besides it contains clear information about the objectives that needs to be achieved. There are a couple of things that we need to consider also in order to improve a little bit the RFC.

1. The document describes that we are going to use an API REST but doesn't explain what is REST.
2. Which technology are we going to use to expose our services? let's bear on mind that we are going to put everything in the API GW that gonna be build in Fastify.
3. The endpoints specification have some mistakes in the contracts dialects

• POST /geolocation/notify-place should be /geolocation/place because the endpoint is a POST it already describes which action are we performing to the place. There is another thing important to notice and is based with the payload because we are not receiving the lat and lon which must be stored, because in the service GET /geolocation/locationreturns this data.
• PUT /geolocation/update-place should be PATCH /geolocation/placebecause PUT is just used when we change the entire document and for our business rules this is no possible, so we should only be able to udpate the address and the placeName
• GET /geolocation/get-places should be /geolocation/places because the GET verb already describes that the endpoint is for read places.
• GET /geolocation/get-locationshould be /geolocation/place/{:id} because we are returning a place based on it's ID.

There is an endpoint that was not described and it is important also to add it and is the endpoint that performs the reverse geolocation, where we provide the lat and lon and we return the name and address.

Pretty good job folks. Let me know if you have more doubts.

[Edilberto-Vazquez]

In reverse geolocation, we provide the latitude and longitude or we will receive the latitude and longitude in the parameters?

[Edilberto-Vazquez]

For example /geolocation/address?lat=45.15646&lon=47.15446

[Edilberto-Vazquez]

We updated our RFC, added changes and some examples of how it will be used on the front-end and places service