Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pxr::UsdMtlxGetPackedUsdValues does not work for vector types #3431

Open
spitzak opened this issue Nov 19, 2024 · 1 comment
Open

pxr::UsdMtlxGetPackedUsdValues does not work for vector types #3431

spitzak opened this issue Nov 19, 2024 · 1 comment

Comments

@spitzak
Copy link

spitzak commented Nov 19, 2024

Description of Issue

Vector MX types have commas in their string representations and pxr::UsdMtlxGetPackedUsdValues assumes they don't.

The MX code appears to just assume there are N-1 commas inside the strings for vectors of size N, so it is probably best to replicate that. It also looks like it would work to split the string at ", " (comma + space) rather than at all commas.

It might be nice to make the _GetUsdValue(string, type) function in pxr/usd/usdMtlx/utils.cpp public as access to that would make working around this much easier.

Steps to Reproduce

Try to get the enumeration list for the ND_luminance_color3 field of a MX Luminance shader.

@jesschimein
Copy link
Contributor

Filed as internal issue #USD-10451

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants