-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't create a new monomer #220
Comments
409 indicates a conflict, so it seems that the MonomerService (erroneously) detects that the same monomer structure has been entered before. |
Okay, this is strange; I've tried it again with the MonomerService deployed on a local docker instance and I'm getting different behaviour than the test server; @scilligence Have you changed any chemistry settings, by any chance? Or is there some other configuration which could differ between the systems? |
Additional point - can the webeditor display the full error code to help debugging? |
Retested using the webeditor on the new Pistoia Docker image http://webeditor.openhelm.org:8000/hwe/examples/MonomerLibApp.htm and I get the same 409 error. |
Really odd. So you see the problem on http://webeditor.openhelm.org:8000/hwe/examples/MonomerLibApp.htm but not on yours despite the fact that they should be the same? |
Yes, with the exact same docker image and input. I had to do the screenshots, because I still feel like "this should not happen". |
The webservices issues have been fixed and we have the latest version of the webservices and webeditor at http://webeditor.openhelm.org:8000/hwe/examples/App.htm. This is now exclusively a webeditor problem. On clicking save in the webeditor, I get the following message: |
I cannot reproduce the "Expected ';'" error above, but did get this error message:
Markus - Is there any change in the Monomer Web Service requiring SMILES now? SMILES can be generated from the input Molfile on the server side. |
Just upgrade web services to latest versions, but the problem is not fixed: Monomerservice 1.1.5 https://oss.sonatype.org/content/repositories/releases/org/pistoiaalliance/helm/helm2-monomerservice/1.1.5/helm2-monomerservice-1.1.5.war |
Hi Tony, could you try it again with the natural analogue as - instead of x. The webservices are expecting x. I think there could be another issue, but lets sort out one thing at a time. Using - as the natural analogue will show you the parsing error. Can you make the next HELM team meeting, so we can go through the issues together? I think we need to do this in order to identify where the problems are. |
Tried using - as natural analogue, and I got the same error message. |
Hmm, I think this is why we need to talk it through. I get the parsing error when using -, so we need to check the other parameters and sort this out together. |
OK, I have done a side-by-side comparison between 54.83.135.171 and webeditor.openhelm.org and there is still a difference between the set-ups. Both use the same monomerservice and webservice versions. I used this example monomer (with no SMILES to check that SMILES can be generated correctly): When I use the PUT method at http://webeditor.openhelm.org:8000/HELM2MonomerService/, I get a successful 200 response. If I try the same input at http://54.83.135.171//HELM2MonomerService/ I get 409, so there is something different about the setups. Full details about how we set our test server up are in the Docker file at https://github.com/PistoiaHELM/pistoiahelm.github.com/tree/master/docker. Please check against the Scilligence environment. Despite the fact that the backend at http://webeditor.openhelm.org:8000/HELM2MonomerService/ works, trying to create the same monomer through http://webeditor.openhelm.org:8000/hwe/examples/MonomerLibApp.htm still generates an error. |
Is there a way we can check the versions of the two installations? |
Yes, and the version number for the HELM2monomerservice is available using the Swagger page at http://webeditor.openhelm.org:8000/WebService/HowToUse.html for our dev server: but the installation at http://54.83.135.171/ seems to use the right versions, so there must be some other difference. It is really odd. Is there something different about the monomer store? The Dockerfile https://github.com/PistoiaHELM/pistoiahelm.github.com/tree/master/docker shows our precise set up. |
I click on the + button to create a new monomer and the dialogue box appears.
I enter information and click save.
I see the following error message.
The text was updated successfully, but these errors were encountered: