Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Returned error messages are not displayed in the editor #166

Closed
ClairePA opened this issue Mar 9, 2018 · 5 comments
Closed

Returned error messages are not displayed in the editor #166

ClairePA opened this issue Mar 9, 2018 · 5 comments
Assignees

Comments

@ClairePA
Copy link
Collaborator

ClairePA commented Mar 9, 2018

If I create an existing monomer with a new symbol an error is generated by the monomerservice. However this error is not displayed to the user.

@scilligence
Copy link
Collaborator

Could you give one specific example? It does pick up the error message received from JSON, and display it.

@ClairePA
Copy link
Collaborator Author

OK, my explanation was not clear. Most of the errors are handled and the user is warned when information is missing on save. There are two examples where this is not done.

Changing a monomer's symbol

Steps:
Edit a monomer and change the symbol.
Save the monomer
It is not updated on save and the user is not warned.

Creating a new monomer with an existing symbol

Steps
Create a new monomer and give it the same symbol as an existing one.
Save the monomer.
On saving the existing one is overwritten so it does not create a duplicate. (creating a duplicate would be bad). It would be better if it warned you first and refused to save at all.

@ClairePA ClairePA removed their assignment Mar 16, 2018
@scilligence
Copy link
Collaborator

Markus,

Could you check this case on the Web Service side?

Here is the response of this RESTful call:
image

And here is the Request data (Only Symbol is changed in this case)
image

@ClairePA
Copy link
Collaborator Author

ClairePA commented Aug 7, 2018

Rechecked and this issue is still there.

@ClairePA
Copy link
Collaborator Author

Moved the examples to issues #215 and #216 to track more accurately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants