Merge pull request #247 from Pinelab-studio/feat/stock-monitoring-bug…

…-fix

Stock Monitoring Plugin Bug FIx

package.json

@@ -28,6 +28,7 @@
     "@graphql-codegen/typed-document-node": "^5.0.1",
     "@graphql-codegen/typescript-document-nodes": "2.2.8",
     "@graphql-codegen/typescript-operations": "2.3.5",
+    "@graphql-codegen/typed-document-node": "^5.0.1",
     "@graphql-codegen/typescript": "2.4.8",
     "@nestjs/cli": "8.2.4",
     "@rollup/plugin-typescript": "11.0.0",

packages/vendure-plugin-stock-monitoring/src/api/stock-monitoring.resolver.ts

@@ -4,11 +4,9 @@ import {
   ProductVariant,
   RequestContext,
   TransactionalConnection,
-  translateEntity,
   Permission,
   Allow,
 } from '@vendure/core';
-import { LessThan } from 'typeorm';
 import { StockMonitoringPlugin } from '../stock-monitoring.plugin';
 
 @Resolver()
@@ -27,9 +25,10 @@ export class StockMonitoringResolver {
       .leftJoin('variant.stockLevels', 'stockLevel')
       .addGroupBy('variant.id')
       .addSelect(['SUM(stockLevel.stockOnHand) as stockOnHand'])
+      .addSelect(['SUM(stockLevel.stockAllocated) as stockAllocated'])
       .leftJoin('product.channels', 'channel')
       .where('variant.enabled = true')
-      .andWhere('stockOnHand < :threshold', {
+      .andWhere('stockOnHand - stockAllocated < :threshold', {
         threshold: StockMonitoringPlugin.threshold,
       })
       .andWhere('variant.deletedAt IS NULL')

packages/vendure-plugin-stock-monitoring/test/stock.spec.ts

@@ -17,7 +17,7 @@ import { createLowStockEmailHandler } from '../src/api/low-stock.email-handler';
 import * as path from 'path';
 import { createSettledOrder } from '../../test/src/shop-utils';
 import * as fs from 'fs';
-import { expect, describe, beforeAll, afterAll, it, vi, test } from 'vitest';
+import { expect, describe, beforeAll, it } from 'vitest';
 describe('Order export plugin', function () {
   let server: TestServer;
   let adminClient: SimpleGraphQLClient;