v1.0 ios #48
Merged
v1.0 ios #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrrostam
reviewed
Jan 27, 2024
| @@ -77,6 +77,8 @@ PV_API pv_status_t pv_get_error_stack( | |||
| */ | |||
| PV_API void pv_free_error_stack(char **message_stack); | |||
|
|
|||
| PV_API void pv_set_sdk(const char *sdk); | |||
There was a problem hiding this comment.
do we want to expose this?
There was a problem hiding this comment.
It's already a public function, but for iOS we have to add this to the head because otherwise the framework will claim that it doesn't exist even though the symbol is there in the actual dylib file. We've done this in the other products, it just hasn't been automated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will release package on approval