Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize/refactor front- vs back-end code #370

Open
kvesik opened this issue Aug 15, 2024 · 1 comment
Open

Reorganize/refactor front- vs back-end code #370

kvesik opened this issue Aug 15, 2024 · 1 comment
Labels
(low priority) refactor refactor, restructure, or reorganize

Comments

@kvesik
Copy link
Collaborator

kvesik commented Aug 15, 2024

The SLP-AA codebase is set up with (most) code contained in gui, lexicon, and models packages. It is almost certainly the case that there is no gui code in the lexicon or models folders. However, @Harukaichii points out that there is a fair amount of code in the UI files that maybe doesn't need to be there. One type would be logic around adding/removing/etc data structures from the underlying corpus once the user has made a selection. Another is the actual programmatic construction of the UI itself-- could this be done via a QML specification file, for example?

Not high priority, but something to think about possibly trying to streamline!

@kvesik kvesik added refactor refactor, restructure, or reorganize (low priority) labels Aug 15, 2024
@Harukaichii
Copy link
Contributor

Harukaichii commented Aug 20, 2024

Clarification: My main concern was less so about "frontend" vs "backend" but more so about "element creation" vs. "business logic" in the front end

I think there's a lot of code dedicated to creating a component or adding it to the UI. Perhaps we can better component-ize (or move to QML?) our UI elements so in the future when I'm looking at a panel class, majority of the code should be about when I'm supposed to show / do something special with a UI element rather than seeing a lot of code about alignment, spacing, layout etc. of a radio group

when I originally spoke about this I didn't explain myself very well so thanks again for documenting my comments :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(low priority) refactor refactor, restructure, or reorganize
Projects
None yet
Development

No branches or pull requests

2 participants