Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Home and Settings Updates #99

Open
wants to merge 31 commits into
base: master
Choose a base branch
from
Open

Home and Settings Updates #99

wants to merge 31 commits into from

Conversation

romil2807
Copy link
Collaborator

@romil2807 romil2807 commented Oct 27, 2024 •
edited by trife
Loading

Closes #90
Closes #95

@romil2807 romil2807 self-assigned this Nov 2, 2024
trife
trife requested changes Nov 16, 2024
View reviewed changes
Copy link
Member

@trife trife left a comment •
edited by kamathprasad9
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Main settings page top toolbar is missing
  • Person dialog doesn't open
  • Create cross ID pattern toolbar has a white gap above it, the text is black instead of matching the other toolbar text, and it says Intercross instead of "Cross ID Pattern"

This was linked to issues Nov 27, 2024
Settings updates #90
Open
Home updates #95
Open
@trife trife requested a review from chaneylc November 27, 2024 19:27
@trife trife changed the title Issue 90 Home and Settings Updates Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trife trife trife approved these changes

@chaneylc chaneylc Awaiting requested review from chaneylc

Assignees

@romil2807 romil2807

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Home updates Settings updates
3 participants
@romil2807 @trife @kamathprasad9