Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

other lib #3

Closed
Rainer-Lang opened this issue Aug 14, 2017 · 4 comments
Closed

other lib #3

Rainer-Lang opened this issue Aug 14, 2017 · 4 comments

Comments

@Rainer-Lang
Copy link

Rainer-Lang commented Aug 14, 2017

Do you know this lib? https://github.com/VictorAlbertos/RxActivityResult

UPDATE: What are the differences? Pros/cons?

@PetarMarijanovic
Copy link
Owner

PetarMarijanovic commented Aug 16, 2017

I believe that you'll be better off with using Victors library since it is more seasoned :)
This is my take on it. I will try to keep it as simple as possible (and working of course), to learn something along the way and to spread the knowledge :)

@Rainer-Lang
Copy link
Author

I like your convenience methods. Maybe it's possible for you to contribute to Victors lib with some of your ideas....?

@PetarMarijanovic
Copy link
Owner

I just did :)
VictorAlbertos/RxActivityResult#47

@AlexTrotsenko
Copy link

AlexTrotsenko commented Sep 26, 2019

@PetarMarijanovic I can't agree with you, that VictorAlbertos lib is better nowdays :)

VictorAlbertos lib "helps" you to perform two things:

  1. Rx api to handle onActivityResult()
  2. Update ui of current activity in . subscribe(). when Rx task is done by handling state of currently active activity .

I believe, that standard LiveData does 2nd job better nowdays. Thus I would like to have simple lib, which does only Rx api part, e.g. task 1 in the list above.

I was about actually to create my own lib doing exactly what you lib already does. Likely I found your lib before doing this. I will try to use it and give the feedback. So far I like it exactly because of simplicity and doing only one dedicated task.

Also I like current approach with "helper fragment". As for me it is more elegant and safe then approach with "helper activity" in VictorAlbertos lib.

Btw, I have updated the same app to demonstrate how this lib works nicely with LiveData to acomplish before-mentioned job: #8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants