Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

line numbers replaced by bullets for poetry? #18

Open
lcerrato opened this issue Sep 19, 2016 · 4 comments
Open

line numbers replaced by bullets for poetry? #18

lcerrato opened this issue Sep 19, 2016 · 4 comments

Comments

@lcerrato
Copy link
Contributor

This looks like a recent change.

screenshot1

screenshot2

@balmas
Copy link
Contributor

balmas commented Sep 20, 2016

Ah, @PonteIneptique this came in with the change to version.xsl applies line number markup ( <ol><li></li></ol>) only to <l/> tags that appear inside divs with @type="textpart". So this works fine with say, Catullus, which has a 2 level citation scheme. But for Hesiod, the lines are that the top level, so the passages don't include a wrapping div of type textpart.

@lcerrato
Copy link
Contributor Author

Thanks!
Another example here I stumbled across.
http://cts.perseids.org/read/greekLit/tlg0003/tlg001/perseus-eng6/1.9.3-1.10.1
@gregorycrane also had comments on a similar formatting issue.

@balmas
Copy link
Contributor

balmas commented Sep 20, 2016

I will try to get a fix for this deployed later today.

balmas added a commit that referenced this issue Sep 20, 2016
@balmas
Copy link
Contributor

balmas commented Sep 20, 2016

I've committed (and deployed) some quick fixes for these two issues (the line numbers in Hesiod and the quoted line in Thuc) but there is still much work to do to make the xslt transforms robust enough for all the variations in the Perseus texts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants