Function Calls in HTML Templates

[meisekimiu]

Angular's change detection causes a component to rerender if a function or method is called inside of it. This means that any components that are calling functions to generate values are being rerendered every single frame, which is not good for performance and can cause other issues (such as reporting several thousand copies of the same error to Sentry). Note that this does not apply to events/outputs where a method is passed in as a callback.

This currently affects several components in web-app. Let's change this, and make new components not call methods inside the templates, unless they're made as Pipes.