Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support retry logic #149

Open
slifty opened this issue Aug 14, 2023 · 1 comment
Open

Support retry logic #149

slifty opened this issue Aug 14, 2023 · 1 comment

Comments

@slifty
Copy link
Contributor

slifty commented Aug 14, 2023

As we explore options for API throttling it might be a useful quality of life to support exponential backoff logic (and, depending on throttling implementation, support for parsing the 429 status code response to detect a Retry-After).

Even without throttling it would be useful to support an optional retry flag when making API calls.

This library exists and looks quite robust: https://github.com/jonbern/fetch-retry

It might be a good option as opposed to implementing this directly ourselves

@slifty
Copy link
Contributor Author

slifty commented Aug 14, 2023

In terms of our own sdk's API, I don't think it is necessary to expose the full API of something like fetch-retry but to either just do it silently (it seems to me this is the opposite of a breaking change) OR make it customizable via the config object but default retry to true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant