WIP: 25 refresh instances #39
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@xmunoz mentioned in #25 that Terraform didn't yet support automatically refreshing instances with new code. This is an issue because, assuming we have multiple autoscaled instances up at a moment when we want to do a code deploy, we need a way to refresh all of those instances with the new code (other than clicking "Refresh" in AWS). Terraform now does support this, as of version 3.22. Their issue: hashicorp/terraform-provider-aws#13785 The pull request: hashicorp/terraform-provider-aws#16678 The changelog: https://github.com/hashicorp/terraform-provider-aws/blob/v3.22.0/CHANGELOG.md Use this new version of the Terraform AWS provider so that we can use autoscaling.
Followed the documentation here: https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/autoscaling_group This is quite experimental (which is why I only changed the dev setup). I tried to use the minimal set of parameters because most of them are optional, but I'm not entirely sure I've given terraform enough information to find the right autoscaling group in AWS.
andrewatwood
approved these changes
Feb 1, 2021
| @@ -30,16 +30,31 @@ variable "perm_env" { | |||
| } | |||
| } | |||
|
|
|||
| resource "aws_autoscaling_group" "dev_api" { | |||
| name = "backend-dev" | |||
| max_size = 5 # does this seem appropriate? | |||
There was a problem hiding this comment.
Previously this was set to a max of 3, but that was arbitrary! 5 seems like a a good end target, assuming we dial in appropriate scaling triggers.
cecilia-donnelly
commented
Feb 9, 2021
| @@ -30,16 +30,31 @@ variable "perm_env" { | |||
| } | |||
| } | |||
|
|
|||
| resource "aws_autoscaling_group" "dev_api" { | |||
There was a problem hiding this comment.
One question we have: do we need to create this autoscaling group or will Terraform build it?
|
Closing this since it's not ready for prime time (have not made corresponding AWS changes). Will reopen as needed when autoscaling becomes a priority again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an autoscaling group and refresh policy to the Terraform dev setup. (Only dev, since this is experimental.) We have two autoscaling groups in AWS, but neither of them are for dev. I assumed that we only wanted to autoscale the "backend" machine, not cron or task-runner, but that might be wrong.
I'm opening this as a place to discuss with @andrewatwood.
Resolves #25.
Related to #23 and #21. I suspect that fixing #21 would be a good thing to include in this PR, too.
Steps to Test
I am not sure how to test this short of redeploying dev, unfortunately. Ideas?