PMM-7 Remove redundant ci-default.yml #3774
Open
+30
−113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talhabinrizwan
approved these changes
Nov 19, 2024
|
Server docker: perconalab/pmm-server-fb:PR-3774-8757353 |
|
API tests have failed: https://pmm.cd.percona.com/job/pmm3-api-tests/1501/ |
BupycHuk
approved these changes
Nov 28, 2024
| @@ -42,8 +44,17 @@ def read_config_override(self): | |||
| return yaml.load(f, Loader=yaml.FullLoader) | |||
|
|
|||
| def read_config(self): | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.percona.com/browse/PMM-7
Problem
We are managing two similar data structures: one in
.gitmodulesand one inci-default.yml. The second one is currently being used byci.py, which combines it with theconfig overrideslocated inci.yml. It turns out, we can still achieve the goal withoutci-default.yml, since the Python script can read as well from the.gitmodulesconfig file.Solution
Get rid of
ci-default.yml, which contains the same data as.gitmodules.This PR does that and it also refactors the code of
ci.py.