-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warnings as error reporting #94
Conversation
Co-authored-by: Mudit Pandey <[email protected]>
Co-authored-by: Mudit Pandey <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mlxd, this looks great. I have a 'conceptual' question. I see that 2 days ago this PR was merged to test PL with warnings promoted to errors once a week.
However, it seems to me that the amount of failures is so large that it's hard to even read the output log (which should be expected since, in principle, there might be a lot of different warnings).
Was the ultimate purpose of the previous PR to have something like the formatted table that you show in the description of this PR?
Thanks @PietropaoloFrisoni For now, polling all the logs and extracted the sections with grep & awk is the fastest path to having the info in one place. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank again!
Co-authored-by: Pietropaolo Frisoni <[email protected]>
This PR adds support for a weekly report using updated data of the warnings as errors PR action in PennyLane. A table is added with the determined warnings (not dynamic due to no templated generation of markdown).
The table ie formatted as follows:
PennyLane
UserWarning
DeprecationWarning
pytest.PytestRemovedIn9Warning
PendingDeprecationWarning
pytest.PytestUnraisableExceptionWarning
numpy.exceptions.ComplexWarning
RuntimeWarning
pytest.PytestCollectionWarning
FutureWarning
pennylane.PennyLaneDeprecationWarning
Data is first collected and preprocessed from the latest https://github.com/PennyLaneAI/pennylane/actions/workflows/package_warnings_as_errors.yml run, with the resulting post-processed data created in a temporary tag under this repo. This creation allows us to use the resulting JSON data file in badges to allow dynamic updates of the above.