-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP][Bug Fix] Fixing the pow
method on qml.TShift
#6356
Open
willjmax
wants to merge
17
commits into
master
Choose a base branch
from
tshift-pow
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello. You may have forgotten to update the changelog!
|
astralcai
reviewed
Oct 8, 2024
Co-authored-by: Astral Cai <[email protected]>
willjmax
changed the title
[Bug Fix] Fixing the
[WIP][Bug Fix] Fixing the Oct 8, 2024
pow
method on qml.TShift
pow
method on qml.TShift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #6355 by providing proper
pow
implementations forqml.TShift
,qml.TAdd
, andqml.TClock
. Each of these operators implementpow
in the following way.This is calling the
pow
method onOperator
which handles the cases forz==0
andz==1
but returns aPowUndefinedError
for any other value ofz
. This leads to an error forTShift
,TAdd
, andTClock
when raising to the second power. This PR implements the case whenz
is a non-negative integer by returning a list containingz
copies of the operator.