Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinning qiskit in setup.py #604

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Pinning qiskit in setup.py #604

merged 2 commits into from
Dec 4, 2024

Conversation

PietropaoloFrisoni
Copy link
Contributor

@PietropaoloFrisoni PietropaoloFrisoni commented Dec 3, 2024

This PR implements a hard pin on qiskit so that the latter automatically downgrades to qiskit 1.2.4 (that works with this plugin) if the latest version of qiskit (that is, qiskit 1.3.0, which does not currently work with this plugin) is installed.

With this hard pin, if a user has the latest version of qiskit and installs the pennylane-qiskit plugin, the qiskit version is automatically downgraded to the previous one (which does not provide wrong results).

Vice versa, if the user installs the latest pennylane-qiskit and then the latest qiskit version, he/she should receive the message:

pennylane-qiskit 0.40.XXX requires qiskit<1.3.0,>=0.32, but you have qiskit 1.3.0 which is incompatible

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (4742bdb) to head (1b0b516).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #604   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          868       868           
=========================================
  Hits           868       868           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PietropaoloFrisoni PietropaoloFrisoni merged commit 0bc0dcf into master Dec 4, 2024
10 checks passed
@PietropaoloFrisoni PietropaoloFrisoni deleted the hard_pin_qiskit branch December 4, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants