Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to retrieve results with v0.3 #96

Merged
merged 6 commits into from
Jan 4, 2024
Merged

Update to retrieve results with v0.3 #96

merged 6 commits into from
Jan 4, 2024

Conversation

lillian542
Copy link
Contributor

@lillian542 lillian542 commented Jan 3, 2024 •
edited
Loading

This makes retrieving simulator results with the v0.3 interface work.

I have no hardware access and we run no hardware tests, so I can't promise that this works for hardware.

@codecov Codecov
Copy link

codecov bot commented Jan 3, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (82ace77) 95.75% compared to head (4e3e930) 96.85%.
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master      #96      +/-   ##
==========================================
+ Coverage   95.75%   96.85%   +1.10%     
==========================================
  Files           5        5              
  Lines         306      318      +12     
==========================================
+ Hits          293      308      +15     
+ Misses         13       10       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lillian542 lillian542 marked this pull request as ready for review January 3, 2024 21:47
@lillian542 lillian542 requested a review from a team January 3, 2024 21:47
timmysilv
timmysilv reviewed Jan 3, 2024
View reviewed changes
Copy link
Contributor

@timmysilv timmysilv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple of questions. also do the device integration tests run on hardware? anyway, they passed so at least there's that

pennylane_ionq/api_client.py Show resolved Hide resolved
pennylane_ionq/device.py Show resolved Hide resolved
@lillian542
Copy link
Contributor Author

lillian542 commented Jan 4, 2024 •
edited
Loading

also do the device integration tests run on hardware?

The answer to this question is always no

@lillian542 lillian542 requested a review from timmysilv January 4, 2024 18:20
timmysilv
timmysilv approved these changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@timmysilv timmysilv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for figuring this all out 🏆

@lillian542 lillian542 merged commit eac7e26 into master Jan 4, 2024
9 checks passed
@lillian542 lillian542 deleted the task_retrieval_bugfix branch January 4, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timmysilv timmysilv timmysilv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lillian542 @timmysilv