From c697f742501ab65439cc78e294613b33901e2e63 Mon Sep 17 00:00:00 2001 From: Stephen L Arnold Date: Mon, 15 Nov 2021 21:01:36 -0800 Subject: [PATCH] fix: remove extra v prefix in release workflow !cosmetic * also limit PR comments to repo owner until refactor Signed-off-by: Stephen L Arnold --- .github/workflows/coverage.yml | 4 +++- .github/workflows/release.yml | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml index 0296238f..b20ac3f3 100644 --- a/.github/workflows/coverage.yml +++ b/.github/workflows/coverage.yml @@ -2,6 +2,7 @@ # needs separate jobs for coverage checkout/run and PR coverage report comment # badge and comment job logic should be tuned for personal vs org use # (see badge job comments below) +# as of Nov 2021: broken on forks, needs much refactoring for previous behavior name: Coverage on: @@ -199,7 +200,7 @@ jobs: - name: Add Coverage PR Comment uses: marocchino/sticky-pull-request-comment@v2.2.0 - if: ${{ github.event_name == 'pull_request' }} + if: ${{ github.event_name == 'pull_request' && github.actor == github.repository_owner }} with: header: coverage path: pr-coverage/code-coverage-results.md @@ -230,6 +231,7 @@ jobs: name: Comment on PR with coverage delta runs-on: ubuntu-20.04 needs: [test, base] + if: ${{ github.actor == github.repository_owner }} steps: - name: Environment diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 65d2499b..f352ff28 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -86,7 +86,7 @@ jobs: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} with: tag_name: ${{ env.VERSION }} - name: Release v${{ env.VERSION }} + name: Release ${{ env.VERSION }} body_path: CHANGES.md draft: false prerelease: false