decks that are pure emoji download as "txt" instead of a sane filename

[vorpal-buildbot]

Reported on Discord by @bakert

[bakert]

Example: https://pennydreadfulmagic.com/decks/252499/

[dunn]

am i right in thinking this isn't specific to emoji, but any deck names that are all non-ascii, since we have to put the filename in the content-disposition header and headers don't like non-ascii?

[bakert]

am i right in thinking this isn't specific to emoji, but any deck names that are all non-ascii, since we have to put the filename in the content-disposition header and headers don't like non-ascii?

Yes I think we probably explicitly filter down to just ascii although I haven't looked at the code in a while.

[dunn]

yeah, that's what's being done: https://github.com/PennyDreadfulMTG/Penny-Dreadful-Tools/blob/master/decksite/deck_name.py#L117

a quick fix would just check if safe_name ends up empty after filtering, and assign it something like untitled.

[bakert]

Sounds alright to me.

[silasary]

Not sure if you want to, but we could throw it through anyascii to make a best-fit ascii name

[dunn]

Not sure if you want to, but we could throw it through anyascii to make a best-fit ascii name

oh neat, if we're ok pulling in another dependency that'd work. though we'd probably need a bit of post-processing (removing the colons around emoji names, etc)

[dunn]

oh, i missed that anyascii is already a dependency; opened a new PR