Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Season chooser dropdown is invalid HTML and not super accessible #12669

Open
bakert opened this issue May 26, 2024 · 0 comments
Open

Season chooser dropdown is invalid HTML and not super accessible #12669

bakert opened this issue May 26, 2024 · 0 comments
Labels
triage Used by bot to label unlabeled tasks, will be removed automatically upon labeling

Comments

@bakert
Copy link
Member

bakert commented May 26, 2024

It's nice that it's pure CSS and doesn't require js but a lot of the site does require js so maybe that doesn't matter.

Putting the menu inside the label is invalid HTML. Could just fix that part. Not sure if label can appear outside a form.

Or we could make a more-accessible version by doing it with js.

@github-actions github-actions bot added the triage Used by bot to label unlabeled tasks, will be removed automatically upon labeling label May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Used by bot to label unlabeled tasks, will be removed automatically upon labeling
Projects
None yet
Development

No branches or pull requests

1 participant