Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edge release update & GitHub test jobs #27

Merged
merged 19 commits into from
Feb 12, 2024
Merged

Edge release update & GitHub test jobs #27

merged 19 commits into from
Feb 12, 2024

Conversation

JanneKiiskila
Copy link
Contributor

@JanneKiiskila JanneKiiskila commented Jan 12, 2024

Mbed Edge Examples pull request

Description

  • Update to latest edge (points to RC1).
  • GitHub actions - make & test, Docker build.
  • Fix to make Docker build work even from an existing folder used for building.
  • Documentation updates.
  • Use the maintained misspell in GitHub action.
  • Update node simple-pt-example Dockerfile node version.

Test instructions

Check list

Changelog

  • CHANGELOG.md updated.

Initial action to make all.
Modify how we run it. One should always run 1st the
sudo apt-get update, only then the install.

Doxygen dependency was missing, this would cause failure
with the make all when building docs.
It will start the protocol translator and well, it will never
stop running.
Move over from v3 to v4.
Canonical is once again pushing snaps, so the normal sudo apt-get
install will fail on Ubuntu 22.04.
There's a new CI machine set up for this repo.
We need to have cmake as well.
Run it with our own machine & take it from the repo that
is maintained.

However, as it's a self-hosted machine - the lib is already
there and it's also initialized. As are the node modules. These
contain LOTS of typos. Thus we must now specify which files/folders
to check (yes, it is a pain).
This causes an issue, if you copy them over with COPY . . and you have
made a local build. It will then have existing fiels produced against
your local directory structure, which will not match what Docker based
build needs.
Update the changelog as well.
Copy link

github-actions bot commented Jan 12, 2024

mbed-edge-examples-result

17 tests   17 ✅  4m 18s ⏱️
 1 suites   0 💤
 1 files     0 ❌

Results for commit 653c2fa.

♻️ This comment has been updated with latest results.

Version 12 is ancient. Version 18 also works just fine.
Fix one type in the README.md.
@JanneKiiskila JanneKiiskila changed the title Edge release update & GItHub test jobs Edge release update & GitHub test jobs Jan 15, 2024
Better to have a larger pool of "client" labeled runners, we can
use the same script/setup for both.
In cleanup, let's delete them...
mqttpt-example/mqttgw_sim/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@petedyerarm petedyerarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JanneKiiskila JanneKiiskila merged commit 0293806 into master Feb 12, 2024
3 checks passed
@JanneKiiskila JanneKiiskila deleted the edge-update branch February 12, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants