GitHub actions, component updates (aiohttp, requests) #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Get some PR-checks in here as well.
Various flake8 fixes., flake8 --exit-zero --exclude=izuma_systest_lib/.eggs,scripts-internal --max-line-length=130 ./izuma_systest_lib/edge/remote_terminal.py:38:22: E711 comparison to None should be 'if cond is None:' ./tests/test_edge_online.py:35:1: F401 'os' imported but unused ./tests/test_edge_online.py:38:1: F401 'izuma_systest_lib.edge.kaas.Kaas' imported but unused ./tests/test_edge_online.py:39:1: F401 'izuma_systest_lib.edge.kubectl.Kubectl' imported but unused ./tests/test_edge_online.py:40:1: F401 'izuma_systest_lib.tools.execute_with_retry' imported but unused ./tests/test_edge_online.py:59:5: F841 local variable 'EPOCH_BASE_DELTA' is assigned to but never used ./tests/test_edge_online.py:84:1: E302 expected 2 blank lines, found 1 ./tests/test_edge_online.py:116:1: E302 expected 2 blank lines, found 1 ./tests/test_edge_online.py:144:1: W391 blank line at end of file ./tests/test_websocket_notifications.py:61:1: E302 expected 2 blank lines, found 1
misspell -i mosquitto . izuma_systest_lib/cloud/libraries/config_management.py:27:38: "managment" is a misspelling of "management" izuma_systest_lib/fixtures/edge_fixtures.py:83:45: "konfiguration" is a misspelling of "configuration" izuma_systest_lib/fixtures/edge_fixtures.py:109:45: "konfiguration" is a misspelling of "configuration" izuma_systest_lib/tools.py:103:13: "Comparision" is a misspelling of "Comparison"
JanneKiiskila
changed the title
jenia81
reviewed
Oct 21, 2023
We have a clean flake8 status now, so let's not check if more was injected - just fail if any are found.
To shut down a few pylint nags. Pylint needs to be the last imported item.
Runs also pytest --collect-only as a test case.
Pylint seems to hate functions names with any capital letters, making them lower case.
Python 3.6 is not supported anymore, pytest does not agree to get installed with the version we're using now.
Seems aiohttp has issues with being able to build with newer Python versions. aio-libs/aiohttp#6600
Pytest as the last one to be imported, so pylint is happier.
It's not running the job, though the file has changed...
There are still some issues with that it seems. aio-libs/aiohttp#6600
Both of these have a vulnerability open, so hike up the version to patch those up.
The master does not have pylintrc, which breaks the test. we can add it later, if need be (the file must be there, otherwise you will have 0 findings from master as it execution fails). pylint --exit-zero --persistent=n tests/ izuma_systest_lib/ >pylint.log vs. pylint --exit-zero --persistent=n --rcfile pylintrc tests/ izuma_systest_lib/ >pylint.log
About the misspell fixes. Add details on the changes done.
Based on review feedback from Jenia. Address needs to be owner/repo only.
This fixes the Python 3.11 issue, it depends on a newer version of
cython, which fixes the 'C includes of "longintrepr.h"' issue
Python 3.12 is still broken, however.
Collecting pyyaml==6.0 (from -r requirements.txt (line 9))
Downloading PyYAML-6.0.tar.gz (124 kB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 125.0/125.0 kB 30.0 MB/s eta 0:00:00
Installing build dependencies: started
Installing build dependencies: finished with status 'done'
Getting requirements to build wheel: started
Getting requirements to build wheel: finished with status 'error'
error: subprocess-exited-with-error
× Getting requirements to build wheel did not run successfully.
│ exit code: 1
╰─> [54 lines of output]
running egg_info
writing lib/PyYAML.egg-info/PKG-INFO
writing dependency_links to lib/PyYAML.egg-info/dependency_links.txt
writing top-level names to lib/PyYAML.egg-info/top_level.txt
Traceback (most recent call last):
File "/opt/hostedtoolcache/Python/3.12.0/x64/lib/python3.12/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 353, in <module>
main()
File "/opt/hostedtoolcache/Python/3.12.0/x64/lib/python3.12/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 335, in main
json_out['return_val'] = hook(**hook_input['kwargs'])
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
JanneKiiskila
force-pushed
the
pr-checks
branch
from
0d2a5f8 to
3a06225
Compare
jenia81
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request template
aiohttp3.8.1 -> 3.8.6requests2.28.1 -> 2.31.0Check list
Testing
Changelog
CHANGELOG.mdupdated.Tagging