PR-checker - pylint improvements (#25)

* Add manual option to run test jobs * PR checker / manual dispatch - add branch handling * PR-checker / get the pylint logs & status counter The updated script in scripts-internal/ci needs a bit of tweaks here. * Regenerated pylintrc -file Match what we have in the system tests repo.
PelionIoT · Dec 20, 2023 · c0add95 · c0add95
1 parent a8cf1e6
commit c0add95
Show file tree

Hide file tree

Showing 3 changed files with 520 additions and 215 deletions.
diff --git a/.github/workflows/installation-test.yml b/.github/workflows/installation-test.yml
@@ -5,6 +5,7 @@ on:
             - 'requirements.txt'
             - 'pytest.ini'
             - '.github/workflows/installation-test.yml'
+    workflow_dispatch:
 
 # This allows a subsequently queued workflow run to interrupt previous runs
 concurrency:
@@ -24,6 +25,9 @@ jobs:
     steps:
       - name: Check out code
         uses: actions/checkout@v3
+        with:
+          # Use the branch specified by the workflow_dispatch input or the pull_request event
+          ref: ${{ github.event.inputs.branch || github.event.pull_request.head.ref }}
       - name: Install Python ${{ matrix.python-ver}}
         uses: actions/setup-python@v4
         with:

diff --git a/.github/workflows/pr-checker.yml b/.github/workflows/pr-checker.yml
@@ -1,9 +1,15 @@
 name: PR-checker
-on: push
+on: 
+    push:
+    workflow_dispatch:
+      inputs:
+          python-version:
+            description: 'Python version to use'
+            default: '3.9'
 
 # This allows a subsequently queued workflow run to interrupt previous runs
 concurrency:
-  group: izuma-system-tests-'${{ github.workflow }} @ ${{ github.event.pull_request.head.label || github.head_ref || github.ref }}'
+  group: e2e-edge-'${{ github.workflow }} @ ${{ github.event.pull_request.head.label || github.head_ref || github.ref }}'
   cancel-in-progress: true
 
 jobs:
@@ -23,8 +29,8 @@ jobs:
         uses: actions/checkout@v4
         with:
           repository: PelionIoT/scripts-internal
+          path: scripts-internal
           token: ${{ secrets.ACCESS_TOKEN }}
-
       # Need to run this 1st, so that the other log files do not cause unnecessary findings
       - name: Run misspell
         if: always()
@@ -48,14 +54,13 @@ jobs:
       - name: Run pylint (findings may not increase)
         run: |
               sudo apt-get install pylint
-              pylint --version
-              pylint --exit-zero --persistent=n tests/ izuma_systest_lib/ >pylint.log
               echo "### pylint" >>$SUMMARY_FILE
-              pylintstats=$(scripts-internal/ci/more-lines-checker.sh ${{ github.event.repository.default_branch }} ${{ github.ref_name }} "pylint --exit-zero --persistent=n systemtest-library test_cases" | tail -n2)
+              pylint --version >>$SUMMARY_FILE
+              pylint --exit-zero --rcfile pylintrc --persistent=n tests/ izuma_systest_lib/ >pylint.log
+              pylintstats=$(scripts-internal/ci/more-lines-checker.sh ${{ github.event.repository.default_branch }} ${{ github.ref_name }} "pylint --exit-zero --rcfile pylintrc --persistent=n tests/ izuma_systest_lib/" pylint | tail -n3)
               echo "$pylintstats" >>$SUMMARY_FILE
               pylintscore=$(tail -2 pylint.log |head -1)
               echo "$pylintscore" >>$SUMMARY_FILE
-              echo "$pylintstats"
               if [[ $pylintstats == *"Oh no"* ]]; then
                 # More findings than earlier
                 echo "TEST_FAIL=true" >> $GITHUB_ENV