Add x25519 Support #88
Open
+494
−110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TJKoury |
|
Great! I need x25519 support as well, for ECDH. |
|
To clarify: I'm aware that you can actually use Ed25519 for ECDH, but most heavily used libraries follow the separation of using Ed25519 for 'sign' & 'verify', and x25519 for 'deriveBits' & 'deriveKey' for ECDH_ES, including Node. Seeing as how all the examples are testing using the Node API, and hopefully the WebCrypto browser standards will follow the Node example, implementing x25519 for completeness seems appropriate for an isomorphic library to bring the browser up to Node's capabilities. |
|
So, thoughts? |
|
Bump |
2 similar comments
|
Bump |
|
Bump |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since integration of the ECDH_ES mech is waiting on this issue, and I need x25519 for a project, I integrated a different crypto library for the time being.
Seems to be passing the test suite copied from the ED mech, though I am certain I missed something.
Standing by for feedback.