Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump version add write #3397

Merged
merged 1 commit into from
Nov 20, 2024
Merged

bump version add write #3397

merged 1 commit into from
Nov 20, 2024

Conversation

robkooper
Copy link
Member

@robkooper robkooper commented Nov 20, 2024

this should fix cache issues (expect many issues to be marked stale)

Description

Motivation and Context

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • My name is in the list of CITATION.cff
  • I agree that PEcAn Project may distribute my contribution under any or all of
    • the same license as the existing code,
    • and/or the BSD 3-clause license.
  • I have updated the CHANGELOG.md.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

this should fix cache issues (expect many issues to be marked stale)
@@ -8,10 +8,15 @@ jobs:
stale:
if: github.repository == 'PecanProject/pecan'

permissions:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my reference: Is a permissions section needed in every workflow now?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, but it is needed here for teh cache, otherwise it keeps processing the same PR/Issues.

@robkooper robkooper added this pull request to the merge queue Nov 20, 2024
Merged via the queue into develop with commit cab30e8 Nov 20, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants