Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull changes that Hamze made for his PR #2380. #3302

Merged
merged 9 commits into from
Jul 12, 2024
Merged

Pull changes that Hamze made for his PR #2380. #3302

merged 9 commits into from
Jul 12, 2024

Conversation

DongchenZ
Copy link
Contributor

Description

Motivation and Context

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • My name is in the list of CITATION.cff
  • I have updated the CHANGELOG.md.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@infotroph infotroph removed the Tests label Jun 26, 2024
@github-actions github-actions bot added the Tests label Jul 12, 2024
@mdietze mdietze enabled auto-merge July 12, 2024 16:00
@mdietze mdietze added this pull request to the merge queue Jul 12, 2024
Merged via the queue into PecanProject:develop with commit c2d63a9 Jul 12, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdietze mdietze mdietze approved these changes

@infotroph infotroph infotroph approved these changes

Assignees
No one assigned
Labels
Modules Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DongchenZ @infotroph @mdietze