-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docker, CI] Allow building pecan/depends from pecan/depends #3260
Merged
infotroph
merged 19 commits into
PecanProject:develop
from
infotroph:allow-depends-update
May 16, 2024
Merged
[Docker, CI] Allow building pecan/depends from pecan/depends #3260
infotroph
merged 19 commits into
PecanProject:develop
from
infotroph:allow-depends-update
May 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infotroph
commented
Feb 15, 2024
@robkooper Discussion questions:
|
infotroph
commented
Feb 15, 2024
/style |
allgandalf
reviewed
May 12, 2024
robkooper
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For discussion -- definitely needs input from @robkooper before merging!
Adds a third option for the dependency image when building Docker images: In addition to "use the existing image" and "build from scratch", adds "try to update an existing image".
Also edits the Docker CI job to check for changed dependencies when building Docker images in a PR branch, and if detected to update the depends image before building other images on top of it.
Additionally and unrelatedly, adds
workflow_dispatch
hooks to several more workflows for easier debugging.Motivation and Context
#3237 is currently failing the Docker CI check because it introduces new version requirements on
dplyr
anddbplyr
that will be satisfied at Depends build time but that Make doesn't know how to resolve. Trying to fix this in the Makefile would add a lot of only-rarely-used complexity, and pre-emptively rebuilding the depends image from scratch on every CI run would be slow and wasteful.Running the depends build only when it will actually change anything (i.e. when the PR touches
docker/depends/*
) is a first step, but it still feels wasteful to wait for all hojillion deps to reinstall when we really only added one or two. Then I realized that the two time-consuming steps in the depends build (apt updates and R package installation) will both skip packages that are already present on the disk -- so if we start from an existing pecan/depends image, adding a layer with the changed dependencies should be fast.Review Time Estimate
Types of changes
Checklist: