Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build more depends versions #3235

Merged
merged 3 commits into from
Nov 23, 2023

Conversation

infotroph
Copy link
Member

@infotroph infotroph commented Nov 22, 2023

Description

  • Adds builds of the depends image with R 4.2 and 4.3
  • Adds the patch utility, which is needed to compile hdf5r on images (e.g. Rdevel) whose CRAN doesn't provide a precompiled binary version.

Motivation and Context

Building the depends image for new versions of R is a necessary upstream step before using them in CI as proposed in #3234, and will facilitate local testing as well. Once this PR is merged and the depends workflow has run, the R 4.2 and 4.3 images will be available for other PRs to use.

I suspect we don't want to keep building 4 versions forever, but we can wait until the new versions are working before turning off any old ones.

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • My name is in the list of CITATION.cff
  • I have updated the CHANGELOG.md.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mdietze mdietze merged commit 797ff18 into PecanProject:develop Nov 23, 2023
10 of 12 checks passed
@infotroph infotroph deleted the build-more-depends-versions branch November 23, 2023 07:13
@mdietze
Copy link
Member

mdietze commented Nov 23, 2023

@infotroph despite pulling this in, there's still not R4.2 and R4.3 versions of pecan/depends at https://hub.docker.com/r/pecan/depends/tags

@infotroph
Copy link
Member Author

@mdietze The build job that pushes to Docker Hub runs at midnight UTC daily -- looks like yesterday's run was just before this merged, but hopefully today's run should pick it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants