Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update confirm_deps.R #3230

Closed
wants to merge 1 commit into from
Closed

Update confirm_deps.R #3230

wants to merge 1 commit into from

Conversation

mdietze
Copy link
Member

@mdietze mdietze commented Nov 3, 2023

grasping at straws on isFalse errors

Description

Motivation and Context

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • My name is in the list of CITATION.cff
  • I have updated the CHANGELOG.md.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mdietze
Update confirm_deps.R
0d34077 
grasping at straws on isFalse errors
@infotroph
Copy link
Member

The right fix for these seems to have been dropping support for R 4.0, so closing this.

@infotroph infotroph closed this Jan 28, 2024
@infotroph infotroph deleted the mdietze-isFalse-patch1 branch May 10, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdietze @infotroph