fix notes/warnings in data.land package #3219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moki1202
force-pushed
the
fix_warnings_dataLand
branch
from
7056153
to
4867bff
Compare
Aariq
reviewed
Sep 29, 2023
moki1202
force-pushed
the
fix_warnings_dataLand
branch
from
4867bff
to
756b1da
Compare
|
Rcheck_reference.log? |
infotroph
requested changes
Dec 2, 2023
There was a problem hiding this comment.
This looks very good! I left a couple of optional formatting suggestions to help tame a few of the very long lines.
The one remaining change I see needed before merging: Please make sure to update Rcheck_reference.log (RESAVE_CHECKS=true Rscript scripts/check_with_errors.R modules/data.land). We should see a LOT of messages disappear from it!
Co-authored-by: Chris Black <[email protected]>
Co-authored-by: Chris Black <[email protected]>
Co-authored-by: Chris Black <[email protected]>
Co-authored-by: Chris Black <[email protected]>
infotroph
reviewed
Feb 9, 2024
infotroph
reviewed
Feb 9, 2024
| @@ -0,0 +1,41 @@ | |||
| test_that("Species matching works", { | |||
There was a problem hiding this comment.
Not actually a new file, just renamed from test.match_species_id.R. Apparently the rearragements I did in other commits before the move are enough to make gitHub treat this and a delete-and-add rather than a rename.
infotroph
reviewed
Feb 13, 2024
infotroph
reviewed
Feb 13, 2024
infotroph
approved these changes
Feb 14, 2024
|
@mdietze Have all your requested changes been addressed? |
mdietze
approved these changes
Feb 14, 2024
Merged
via the queue into
PecanProject:develop
with commit Feb 14, 2024
3664f75
7 of 12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.