fix check warnings/notes in assim.batch package #3200
Conversation
|
@moki1202 Looks like this is just waiting for an updated Rcheck_reference.log |
moki1202
force-pushed
the
assimBatch_notes_fix
branch
from
5fa3ddf to
687d97f
Compare
@infotroph @mdietze done! |
| @@ -140,9 +71,32 @@ File ‘PEcAn.assim.batch/R/pda.get.model.output.R’: | |||
| OK | |||
| * checking for unstated dependencies in vignettes ... OK | |||
| * checking package vignettes in ‘inst/doc’ ... OK | |||
| * checking re-building of vignette outputs ... OK | |||
| * checking re-building of vignette outputs ... WARNING | |||
There was a problem hiding this comment.
I understand that this gets us around the isFalse issue, but I don't feel great about switching a reference log from an OK to a WARNING (the idea of the log was to only move in the direction towards fewer warnings)
| get.da.data: no visible binding for global variable ‘ensemble.samples’ | ||
| get.da.data : <anonymous>: no visible binding for global variable | ||
| ‘sa.samples’ | ||
| get.da.data: no visible binding for global variable ‘sa.samples’ | ||
| get.da.data : <anonymous>: no visible global function definition for |
There was a problem hiding this comment.
Not required for the PR, but I'm curious what's up with read.output.type and why this one undefined variable was left?
There was a problem hiding this comment.
@mdietze I think I remember this. I was unable to find which package does read.output.type function belong to.
There was a problem hiding this comment.
Looking at those functions, I suspect get.da.data.growth.R and get.da.data.R can both be moved from the /R folder to the /inst folder. I don't have time to go through all the code in detail, but I think most of what's here is redundant with newer code by @istfer and others. This code doesn't appear to be operationally linked to other bits of the PDA and the value of retaining this code is primarily because it provides a record of what Carl Davidson did in his (still unpublished) Master thesis.
Co-authored-by: Chris Black <[email protected]>
ea5fc6b
No description provided.