Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PADV-741: Check Pearson Advance references - pearson-release/olive.stage #106

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

Serafin-dev
Copy link

@Serafin-dev Serafin-dev commented Nov 6, 2023

Description

Overwrote all mylearningx references and removed decorative background images that no longer exist.

How to test

  • Start your devstack instance -> make dev.up
  • Open the email template on '{DEVSTACK_WORKSPACE}/src/ace_messages/15.20231106-152132.html'

…learningx.pearson.com/static/pearson-pols-theme/images/PearsonLogo_Primary_Blk_RGB.png' to 'partner-courses.pearson.com/static/pearson-theme/images/logo.png', and removed the decorative background images.
@Serafin-dev Serafin-dev changed the title PADV-741: Check Pearson Advance references. PADV-741: Check Pearson Advance references - pearson-release/olive.stage Nov 8, 2023
@Serafin-dev Serafin-dev requested a review from Jacatove November 9, 2023 20:35
Copy link

@Jacatove Jacatove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Serafin-dev Emails look good, thanks. Would you show the resulting message to our Product owner for approval?.

Don't forget to check the email origin, you probably also need to change that, but that is within our setting in the tutor-pearson plugin.

image

@Serafin-dev Serafin-dev requested a review from Jacatove November 10, 2023 15:12
@Serafin-dev Serafin-dev merged commit 4187ab8 into pearson-release/olive.stage Nov 21, 2023
4 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants