Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submit button fixes #1175

Merged
merged 5 commits into from
Aug 11, 2023
Merged

Submit button fixes #1175

merged 5 commits into from
Aug 11, 2023

Conversation

thet
Copy link
Member

@thet thet commented Aug 11, 2023

Fixes a problem recently reported by @cornae

  • Submitting pat-inject enabled forms without an action attribute but a submit button with a formaction attribute would break pat-ajax.

This fixes also two other problems I found on the way:

  • Submitting with a formaction-button called a pat-ajax method twice.
  • pat-inject did not support submit buttons without an explicit type="submit" attribute, e.g. <button>, which is implicitly a submit button.

…hout an action attribute.

The URL can still be set via the data-pat-ajax attribute.
This fixes a problem where pat-inject enabled forms without an action attribute
but a submit button with a formaction attribute would break.
@thet thet merged commit ebdeaf4 into master Aug 11, 2023
1 check passed
@thet thet deleted the submit-button-fixes branch August 11, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant