Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PCH: let me preview a smart link recommendation from the review modal #2683

Open
danielabloch opened this issue Jul 31, 2024 · 2 comments
Open
Milestone

Comments

@danielabloch
Copy link

Is your feature request related to a problem?

As someone using Smart Links, I would like a shortcut in the review modal to let me preview a smart link you are recommending I add to the draft post. If I can preview that post by selecting the preview icon in the modal, I would expect the Smart Link suggestion to preview in a new tab in my browser window. That way I can review the post you are suggesting and refresh my memory of that post.

Describe the solution you'd like

  • In the Review Smart Links modal, show me an option to preview the post you are suggesting I add to the draft post.
  • In the Review Smart Links modal, when I select the preview option, I expect the post I am previewing to display in a new tab in my browser window. That way I can skim the suggested post and tab back to the Smart Links modal when I am ready to do so again, without losing my place.
  • Instead of showing that the suggestion is a Post we could use that space in the modal to place the preview icon.
stats-in-smart-link-modal

Describe alternatives you've considered

None but open to suggestions

@danielabloch danielabloch added this to the 3.17.0 milestone Jul 31, 2024
@acicovic
Copy link
Collaborator

acicovic commented Aug 9, 2024

Putting this here so we don't forget: According to internal feedback, it might make sense to keep the post type instead of totally replacing it with the icon. Something to discuss when we look into this.

@acicovic
Copy link
Collaborator

@danielabloch, @dabowman: Now that we're designing this, we should see if we keep the post type label or not.

@acicovic acicovic modified the milestones: 3.17.0, 3.18.0, 3.19.0 Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants