Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fastani version issue #135

Open
topkent opened this issue Jul 9, 2024 · 2 comments · Fixed by bioconda/bioconda-recipes#52372
Open

fastani version issue #135

topkent opened this issue Jul 9, 2024 · 2 comments · Fixed by bioconda/bioconda-recipes#52372

Comments

@topkent
Copy link

topkent commented Jul 9, 2024

I installed fastani through conda from bioconda channel.

Using "conda list fastani", it shows
fastani 1.34 h4dfc31f_2 bioconda

However, the "fastANI -v" shows
version 1.33

Why? What's wrong?

@peterjc
Copy link

peterjc commented Nov 25, 2024

Confirming on my macOS machine:

❯ conda list fastani
# packages in environment at /Users/XXX/miniforge3/envs/pyani-plus_py312:
#
# Name                    Version                   Build  Channel
fastani                   1.34                 ha9a6269_3    bioconda

❯ fastANI --version
version 1.33

Looking at the tagged source code for v1.34 this is a bug in fastANI itself (not BioConda's fault):

https://github.com/ParBLiSS/FastANI/blob/v1.34/src/map/include/parseCmdArgs.hpp#L196

i.e. fastANI v1.34 wrongly claims to be 1.33.

@peterjc
Copy link

peterjc commented Nov 26, 2024

The BioConda package for fastANI v1.34 has been patched to report the correct version:

bioconda/bioconda-recipes#52372

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants