Allow changing values of metadata labels #157
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evalott100
force-pushed
the
154-allow-changing-values-of-metadata-labels
branch
from
5a67c63 to
dfebd66
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #157 +/- ##
==========================================
- Coverage 91.89% 91.88% -0.01%
==========================================
Files 8 8
Lines 1419 1430 +11
Branches 168 171 +3
==========================================
+ Hits 1304 1314 +10
Misses 82 82
- Partials 33 34 +1 ☔ View full report in Codecov by Sentry. |
evalott100
force-pushed
the
154-allow-changing-values-of-metadata-labels
branch
from
dfebd66 to
1590ad4
Compare
coretl
reviewed
Dec 19, 2024
| @@ -871,6 +871,7 @@ def standard_responses(table_field_info, table_data_1, table_data_2): | |||
| values={ | |||
| "PCAP.TRIG_EDGE": "Either", | |||
| "PULSE.DELAY.UNITS": "s", | |||
| "*METADATA.LABEL_PULSE1": "ANewLabel", | |||
There was a problem hiding this comment.
Is there a test that checks the label now has this value?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #154
@olliesilvester
Tested to work with real panda.