Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore-sensitive-files-pr check isn't skipping check when label is added #2699

Closed
JiyaGupta-cs opened this issue Nov 19, 2024 · 2 comments
Closed
Assignees
Labels
bug Something isn't working ignore-sensitive-files-pr The contributor has a legitimate reason for editiing protected files

Comments

@JiyaGupta-cs
Copy link

JiyaGupta-cs commented Nov 19, 2024

Describe the bug
GitHub Action Fails to Detect Changes in Sensitive Files Properly
The ignore-sensitive-files-pr label isn't working as expected, causing the workflow to fail even when the label is applied to the pull request.

To Reproduce
Steps to reproduce the behavior:

  • Create a pull request (PR) modifying files listed as sensitive in the workflow.
  • Add the ignore-sensitive-files-pr label to the PR after its creation.
  • Observe that the GitHub Action does not rerun and fails to detect the label properly.
  • The action incorrectly flags changes in sensitive files as unauthorized despite the label.

Expected behavior
When the ignore-sensitive-files-pr label is added to a PR, the GitHub Action should ignore any changes in sensitive files listed in the workflow and not trigger an error.

Actual behavior
The workflow fails even when the ignore-sensitive-files-pr label is added. The sensitive file changes are still flagged as unauthorized, causing unnecessary workflow failures.

References
#2695

@varshith257 Pls assign the issue

@JiyaGupta-cs JiyaGupta-cs added the bug Something isn't working label Nov 19, 2024
@github-actions github-actions bot added ignore-sensitive-files-pr The contributor has a legitimate reason for editiing protected files unapproved Unapproved for Pull Request labels Nov 19, 2024
Copy link

Congratulations on making your first Issue! 🎊 If you haven't already, check out our Contributing Guidelines and Issue Reporting Guidelines to ensure that you are following our guidelines for contributing and making issues.

@varshith257 varshith257 removed the unapproved Unapproved for Pull Request label Nov 19, 2024
@varshith257 varshith257 changed the title Bug Report ignore-sensitive-files-pr check isn't skipping check when label is added Nov 19, 2024
@palisadoes
Copy link
Contributor

This isn't valid. The tests work in the develop and develop-postgres branches as expected.

It will be applied to the main branch in the next merge from the develop-postgres branch.

Closing

@palisadoes palisadoes closed this as not planned Won't fix, can't repro, duplicate, stale Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ignore-sensitive-files-pr The contributor has a legitimate reason for editiing protected files
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants