-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot read properties of undefined (reading 'pageTitle') #35
Comments
I forked the code and debugged it. I found that the issue lies with the filter. The filter restricts the pages involved in the current generation, but the pages reference other pages that are not included in this generation, causing the error. |
Thanks for contributing! Until now, filtering pages means you need to take care of the "page dependencies" to avoid broken links. The PR now would introduce a behaviour that makes it legit to have broken links and i am not sure about that. Maybe we should cover this with an explicit knob to be configured to actively agree that this is intended, instead of implicitly forcing that. What do you think? I could think of a setting like |
Yes, I completely agree with your point of view. Some people prefer to ignore non-existent references to prioritize passing the compilation, while others prefer the compilation to fail to highlight which reference files were missed. Providing an option is the right approach. |
just checking to avoid duplicate efforts, @beyondlex are you working on this and come up with a PR at some point? (no time pressure) :) |
I found out that exactly the same error (
UPD: Correction, this only happens if I have |
Hi @PacoVK , I got the same message when trying to include an image using Kind regards |
When I execute the antora command, i get the following error:
Here is my configuration:
Is there something wrong with my configuration? Thank you for your help!
The text was updated successfully, but these errors were encountered: