Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No uninstall entry created #3

Open
Cubox opened this issue Apr 29, 2019 · 2 comments
Open

No uninstall entry created #3

Cubox opened this issue Apr 29, 2019 · 2 comments

Comments

@Cubox
Copy link

Cubox commented Apr 29, 2019

After installation on Windows, no uninstall entry is created.
While the software is quite light, it is quite a standard by now.

Bonus points if libtap is removed as well (if it is not needed by anyone else)

@0xa
Copy link
Contributor

0xa commented Apr 29, 2019

I don't see how we could know for sure nothing else needs TAP, but we can add an uninstall entry for the software itself at least.
It's terribly documented but looks doable. https://docs.microsoft.com/en-us/windows/desktop/msi/uninstall-registry-key

@Cubox
Copy link
Author

Cubox commented Apr 29, 2019

The TAP part is not mandatory, maybe prompt the user if they want to uninstall it as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants