Split PirateCoinsPage into 2 Pages
#244
Conversation
✅ Deploy Preview for pattonville-wallet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
lishaduck
force-pushed
the
usersplit
branch
2 times, most recently
from
ba7409e
to
31d93eb
Compare
lishaduck
changed the title
PirateCoinsPage into 2 Pages
| # start of code generated by package:dart_define, DO NOT modify or remove these comments | ||
| dart_define.json | ||
| # end of code generated by package:dart_define, DO NOT modify or remove these comments | ||
|
|
There was a problem hiding this comment.
I'm removing it in #256 anyway, so it's not a big deal.
| page: PirateCoinsTeacherRoute.page, | ||
| path: "pirate-coins-teacher", | ||
| children: [ | ||
| AutoRoute( | ||
| page: StatsRoute.page, | ||
| path: "stats", | ||
| title: (context, route) => "Stats", | ||
| ), | ||
| ], | ||
| title: (context, route) => "Pirate Coins", | ||
| ), | ||
| AutoRoute( | ||
| page: PirateCoinsStudentRoute.page, | ||
| path: "pirate-coins-student", |
There was a problem hiding this comment.
It would be better for these to be nested and the difference in routes invisible, at least to students.
| @@ -35,7 +35,8 @@ List<AppletEntity> get _applets { | |||
| image: appletsFolder.pirateCoins.path, | |||
| color: const Color.fromARGB(255, 122, 194, 129), | |||
| // TODO(lishaduck): figure out how to use routes to keep this type-safe. | |||
| location: "/pirate-coins", | |||
| location: | |||
| "/pirate-coins-student", //not sure how to make this dynamic based on account type | |||
There was a problem hiding this comment.
Using route guards should remove to need to hardcode to student. And yes, I know it's not possible right now, which is why I'm working on #253.
There was a problem hiding this comment.
While you're at it, could you write some more tests to verify everything works here? I usually use Copilot to generate a basic test, and enhance it from there which makes it easier.
There was a problem hiding this comment.
Yeah was kinda planning to do that since the old ones were failing
There was a problem hiding this comment.
Oh, and it's the router tests failing, by the way. That's why, we should a) use go_router,1 b) nest the routes.
Footnotes
-
I think it supports extracting the URL from a route, which is also needed for type-safe routing in the dashboard. ↩
|
Are you willing to take another go at this, @ParkerH27 / @PetalCat? |
|
maybe... i gotta try and figure out what is going on |
|
@PetalCat? You still wanna finish this? |
|
I assume this can be closed, @ParkerH27? |
lishaduck
force-pushed
the
main
branch
4 times, most recently
from
bb68a12
to
e5e9b68
Compare
Description
This PR splits the user views for the Pirate Coins feature.
Closes: #192
Type of Change