Live single fits combined bug (gwastro#4449)

* Take precentile of rate, not count * make change to mean as well * Fix to label * Update bin/live/pycbc_live_plot_combined_single_fits Co-authored-by: Tito Dal Canton <[email protected]> * Update bin/live/pycbc_live_combine_single_fits --------- Co-authored-by: Tito Dal Canton <[email protected]>
PRAVEEN-mnl · Nov 3, 2023 · 56fb660 · 56fb660
1 parent ded94af
commit 56fb660
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/bin/live/pycbc_live_combine_single_fits b/bin/live/pycbc_live_combine_single_fits
@@ -161,9 +161,11 @@ for ifo in args.ifos:
         cons_alpha = np.percentile(a, 100 - args.conservative_percentile)
         cons_alphas_out[ifo][counter] = cons_alpha
         alphas_out[ifo][counter] = mean_alpha
-        cons_count = np.percentile(c, args.conservative_percentile)
-        cons_counts_out[ifo][counter] = cons_count * len(c)
-        counts_out[ifo][counter] = c.sum()
+        # To get the count values, we need to convert to rates and back again
+        r = c / l_times[ad_order]
+        cons_rate = np.percentile(r, args.conservative_percentile)
+        cons_counts_out[ifo][counter] = cons_rate * l_times[ad_order].sum()
+        counts_out[ifo][counter] = np.mean(r) * l_times[ad_order].sum()
 
         fout_ifo[f'separate_fits/bin_{counter:d}/fit_coeff'] = a
         fout_ifo[f'separate_fits/bin_{counter:d}/counts'] = c

diff --git a/bin/live/pycbc_live_plot_combined_single_fits b/bin/live/pycbc_live_plot_combined_single_fits
@@ -189,7 +189,7 @@ for ifo in ifos:
     count_labels = [l.get_label() for l in count_lines]
     ax_count.legend(count_lines, count_labels, loc='lower center',
                     ncol=5, bbox_to_anchor=(0.5, 1.01))
-    ax_count.set_ylabel('Counts per live time')
+    ax_count.set_ylabel('Rate of triggers above fit threshold [s$^{-1}$]')
 
     for ax in [ax_count, ax_alpha]:
         ax.set_xticks(xtix)