Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup targets.py #54

Open
4 tasks
felker opened this issue Jan 6, 2020 · 1 comment
Open
4 tasks

Cleanup targets.py #54

felker opened this issue Jan 6, 2020 · 1 comment

Comments

@felker
Copy link
Member

felker commented Jan 6, 2020

  • Consider renaming TTDTarget to LogTTDTarget for clarity
  • 7x threshold_range() class methods are never called anywhere. Vestige of old ROC calculation, e.g. in https://github.com/PPPLDeepLearning/plasma-python/blob/v0.9/plasma/utils/performance.py
  • MaxHingeTarget.loss() (method unique to that class) is unused
  • Base class Target is an invalid configuration option (predicts TTD directly, without the 0 mask before T_warning like in TTDLinearTarget?)

Related to #53, and the broader efforts of #42.
felker added a commit that referenced this issue Jan 6, 2020
@felker
Note unused functions in targets.py
63b8d2d 
See #54
@felker
Copy link
Member Author

felker commented Jan 13, 2020

Related: eb8f664

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@felker