-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/67 startup screen #91
base: development
Are you sure you want to change the base?
Conversation
…installation.md was modified
Reviewed 2 of 20 files at r1. pllug-presentation-system/qpm .exe, line 0 [r1] ([raw file](https://github.com/pllug/pllug-presentation-system-2/blob/34c27fe2196ffd7a949da88d3f84a8c94ced6793/pllug-presentation-system/qpm .exe#L0)): Comments from Reviewable |
Review status: 2 of 20 files reviewed at latest revision, 2 unresolved discussions. doc/workflow/qpm_packages_installation.md, line 5 [r1] (raw file):
Please, mention, that we need to Comments from Reviewable |
Reviewed 2 of 20 files at r1. pllug-presentation-system/resources/qml/main.qml, line 16 [r1] (raw file):
Please, create separate element for Startup window. Comments from Reviewable |
Review status: 4 of 20 files reviewed at latest revision, 4 unresolved discussions. pllug-presentation-system/resources/qml/main.qml, line 14 [r1] (raw file):
Give appropriate name for window Comments from Reviewable |
…reated, qpm installation md was edited
Review status: 1 of 20 files reviewed at latest revision, 5 unresolved discussions. pllug-presentation-system/pllug-presentation-system.pro, line 22 [r2] (raw file):
Please, remove this, as you have your Comments from Reviewable |
Reviewed 2 of 6 files at r2. pllug-presentation-system/resources/qml/qml files/StartupScreen.qml, line 7 [r2] ([raw file](https://github.com/pllug/pllug-presentation-system-2/blob/89218a2c8a6bce086bc59915bb2e0d385c28ae94/pllug-presentation-system/resources/qml/qml files/StartupScreen.qml#L7)):
Please, move setting of height and width to main.qml, where you create StartupScreen element. Comments from Reviewable |
Review status: 3 of 20 files reviewed at latest revision, 7 unresolved discussions. pllug-presentation-system/resources/qml/qml files/StartupScreen.qml, line 10 [r2] ([raw file](https://github.com/pllug/pllug-presentation-system-2/blob/89218a2c8a6bce086bc59915bb2e0d385c28ae94/pllug-presentation-system/resources/qml/qml files/StartupScreen.qml#L10)):
Why you wrap FocusScope into Rectangle? Why do not use only FocuseScope ? Comments from Reviewable |
Review status: 3 of 20 files reviewed at latest revision, 8 unresolved discussions. pllug-presentation-system/resources/qml/qml files/StartupScreen.qml, line 12 [r2] ([raw file](https://github.com/pllug/pllug-presentation-system-2/blob/89218a2c8a6bce086bc59915bb2e0d385c28ae94/pllug-presentation-system/resources/qml/qml files/StartupScreen.qml#L12)):
If you know, that your child item will inherit sizes from his parent, use Comments from Reviewable |
Review status: 3 of 20 files reviewed at latest revision, 9 unresolved discussions. pllug-presentation-system/resources/qml/qml files/StartupScreen.qml, line 10 [r2] ([raw file](https://github.com/pllug/pllug-presentation-system-2/blob/89218a2c8a6bce086bc59915bb2e0d385c28ae94/pllug-presentation-system/resources/qml/qml files/StartupScreen.qml#L10)):
|
Review status: 3 of 20 files reviewed at latest revision, 9 unresolved discussions. pllug-presentation-system/resources/qml/qml files/StartupScreen.qml, line 9 [r2] ([raw file](https://github.com/pllug/pllug-presentation-system-2/blob/89218a2c8a6bce086bc59915bb2e0d385c28ae94/pllug-presentation-system/resources/qml/qml files/StartupScreen.qml#L9)):
Please, remove width and height here. Comments from Reviewable |
Review status: 3 of 20 files reviewed at latest revision, 9 unresolved discussions. pllug-presentation-system/vendor/vendor.pri, line 1 [r2] (raw file): Please, remove folder vendor from repository. Comments from Reviewable |
Review status: 3 of 20 files reviewed at latest revision, 9 unresolved discussions. pllug-presentation-system/resources/qml/qml files/StartupScreen.qml, line 19 [r2] ([raw file](https://github.com/pllug/pllug-presentation-system-2/blob/89218a2c8a6bce086bc59915bb2e0d385c28ae94/pllug-presentation-system/resources/qml/qml files/StartupScreen.qml#L19)):
|
This change is